OCaml Forge

Detail: [#1269] use of undocumented OCaml feature

Bugs: Browse | Download .csv | Monitor

[#1269] use of undocumented OCaml feature

Date:
2013-03-28 16:21
Priority:
3
State:
Open
Submitted by:
Damien Doligez (doligez)
Assigned to:
Nobody (None)
Resolution:
None
Severity:
trivial
Version:
None
Component:
GettextCamomile (pure OCaml)
Operating System:
All
 
Summary:
use of undocumented OCaml feature

Detailed description
At the end of gettextCharset.ml, we find this code:

module Dummy : CHARSET_TYPE =
struct
type encoding = string
type u = ()
let create t in_enc out_enc = ()
let recode () str = str
end
;;

This works, but only because OCaml accepts () as a constructor name in a concrete type definition (your type "u" is not equal to unit!). This is an undocumented feature that will probably be removed in a future version of OCaml, so I suggest that you change that line to "type u = unit", which is probably what you intended anyway.

Thanks -- Damien

Followup

No Followups Have Been Posted

Attached Files:

Changes:

No Changes Have Been Made to This Item