OCaml Forge

Detail: [#1382] OASIS 0.4.3 does horrible makefiles and configure

Bugs: Browse | Download .csv | Monitor

[#1382] OASIS 0.4.3 does horrible makefiles and configure

Date:
2014-03-25 11:20
Priority:
5
State:
Closed
Submitted by:
Jacques-Pascal Deplaix (jpdeplaix)
Assigned to:
Sylvain Le Gall (gildor-admin)
Product:
OASIS
Due in version:
0.4.4
Resolution:
Fixed
Severity:
None
Version:
0.4.3
Component:
None
Operating System:
None
 
URL:
Summary:
OASIS 0.4.3 does horrible makefiles and configure

Detailed description
It removes double \n and gives unreadable Makefile

Followup

Message
Date: 2014-03-25 12:38
Sender: Sylvain Le Gall

The fact that it is only in the OASIS section "mitigate" the importance and it will be fixed by a simple upgrade. The fix is easy so I plan to do a release tonight to get rid of this bug and avoid large impact of the bug.
Date: 2014-03-25 12:15
Sender: Jacques-Pascal Deplaix

Only in the OASIS section.

For example if you just upgrade oasis and, on a project that use oasis 0.4.2, you do « oasis setup, then you will have the following diff:
diff --git a/Makefile b/Makefile
index 025f7ed..d72953a 100644
--- a/Makefile
+++ b/Makefile
@@ -1,40 +1,29 @@
# OASIS_START
-# DO NOT EDIT (digest: 7b2408909643717852b95f994b273fee)
-
+# DO NOT EDIT (digest: a3c674b4239234cbbe53afe090018954)
SETUP = ocaml setup.ml
-
build: setup.data
$(SETUP) -build $(BUILDFLAGS)
-
doc: setup.data build
$(SETUP) -doc $(DOCFLAGS)
-
test: setup.data build
$(SETUP) -test $(TESTFLAGS)
-
all:
$(SETUP) -all $(ALLFLAGS)
-
install: setup.data
$(SETUP) -install $(INSTALLFLAGS)
-
uninstall: setup.data
$(SETUP) -uninstall $(UNINSTALLFLAGS)
-
reinstall: setup.data
$(SETUP) -reinstall $(REINSTALLFLAGS)
-
clean:
$(SETUP) -clean $(CLEANFLAGS)
-
distclean:
$(SETUP) -distclean $(DISTCLEANFLAGS)
-
setup.data:
$(SETUP) -configure $(CONFIGUREFLAGS)
-
+configure:
+ $(SETUP) -configure $(CONFIGUREFLAGS)
.PHONY: build doc test all install uninstall reinstall clean distclean configure
-
# OASIS_STOP
Date: 2014-03-25 12:05
Sender: Sylvain Le Gall

Is it when generating Makefile, in the OASIS section or outside of it ?

If you send me an example, I can do a quick release tonight to fix that.

Attached Files:

Changes:

Field Old Value Date By
status_idOpen2014-03-26 01:27gildor-admin
close_dateNone2014-03-26 01:27gildor-admin
ResolutionNone2014-03-26 01:27gildor-admin
priority32014-03-25 12:09gildor-admin
assigned_tonone2014-03-25 12:09gildor-admin
ProductNone2014-03-25 12:09gildor-admin
Due in versionNone2014-03-25 12:09gildor-admin
VersionNone2014-03-25 12:09gildor-admin