OCaml Forge
SCM

Detail: [#824] Box.vblock does not use the parameter ~padding

Bugs: Browse | Download .csv | Monitor

[#824] Box.vblock does not use the parameter ~padding

Date:
2010-12-03 14:54
Priority:
3
State:
Open
Submitted by:
Vincent Aravantinos (aravantv)
Assigned to:
Nobody (None)
Resolution:
Fixed
Severity:
trivial
Version:
None
Operating System:
All
URL:
 
Summary:
Box.vblock does not use the parameter ~padding

Detailed description
Current code for vblock in Box.ml is the following:

1 let vblock ?padding ?(pos=`Center) ?name ?stroke ?pen ?dash
2 ?min_height ?same_height pl =
3 group ?name
4 (List.map (modify_box ?stroke ?pen ?dash)
5 (vbox_list ~pos ?min_height ?same_height
6 (List.map (set_width (extracth pos) (max_width pl)) pl)))

At line 5, vbox_list should also be provided with "?padding" which is not the case right now. Consequently padding has no influence on the behaviour of the function.

Compare for instance with hblock which is defined correctly:

1 let hblock ?padding ?(pos=`Center) ?name ?stroke ?pen ?dash
2 ?min_width ?same_width pl =
3 group ?name
4 (List.map (modify_box ?stroke ?pen ?dash)
5 (hbox_list ?padding ~pos ?min_width ?same_width
6 (List.map (set_height (extractv pos) (max_height pl)) pl)))

Easy bugfix.

Followup

Message
Date: 2010-12-06 11:00
Sender: Romain Bardou

Fixed in the git repository, thanks Vincent ;)

Attached Files:

Changes:

Field Old Value Date By
ResolutionNone2010-12-06 11:00doomeer