OCaml Forge
SCM

Detail: [#1263] Pull Request

Bugs: Browse | Download .csv | Monitor

[#1263] Pull Request

Date:
2013-03-15 03:51
Priority:
3
State:
Closed
Submitted by:
Romain Beauxis (toots5446)
Assigned to:
ygrek (ygrek)
Resolution:
Fixed
Severity:
None
Summary:
Pull Request

Detailed description
Hi,

I have made some change on the code. Here's a diff, perhaps you'd like to include them:
https://github.com/toots/ocaml-winsvc/commit/6074ef7c37219f4be8276ac9010186b8891b338a

It contains:
* A switch back to stop callback instead of boolean ref. I think it is more elegant in functional context and also easier to make thread-safe for the user.
* An additional "arguments" field to support setting arguments to the service.

Please let me know what you think,
Romain

Followup

Message
Date: 2013-08-06 10:35
Sender: ygrek

Thanks for the patch, commited. I will probably rename the main module to WindowsService, is it ok with you?
Date: 2013-08-06 08:32
Sender: ygrek

Sorry, I didn't notice this bug earlier. IIUC the repo now lives at https://github.com/savonet/ocaml-winsvc and judging from the code it is used in windows liquidsoap so I presume it is working ok for you :) because I don't have a windows machine at hand to check, but the code looks fine..
The boolean ref was the only way in old times when there was no way to register thread with ocaml runtime.
Date: 2013-03-15 05:56
Sender: Romain Beauxis

Sorry, I have just updated the code to fix ocaml thread/callbacks and also properly escape arguments:
https://github.com/toots/ocaml-winsvc/commit/5191a8d5cd688394da505c9a0019518a5bc40046

Attached Files:

Changes:

Field Old Value Date By
close_dateNone2013-08-06 10:35ygrek
ResolutionNone2013-08-06 10:35ygrek
status_idOpen2013-08-06 10:35ygrek
assigned_tonone2013-08-06 08:32ygrek