OCaml Forge
SCM

Detail: [#1302] AskFollow's function result is interpreted differently than documented

Bugs: Browse | Download .csv | Monitor

[#1302] AskFollow's function result is interpreted differently than documented

Date:
2013-08-01 19:09
Priority:
3
State:
Open
Submitted by:
Hezekiah Carty (hcarty)
Assigned to:
Nobody (None)
Resolution:
None
Severity:
normal
Version:
None
Operating System:
Linux
Summary:
AskFollow's function result is interpreted differently than documented

Detailed description
A function passed into FileUtil.find's ~follow parameter with the AskFollow constructor is logically flipped from what the documentation states. The documentation states that a file will be skipped if the function's return value is false. In the code however a true return value indicates that the given link should be skipped.

Followup

Message
Date: 2013-10-05 11:30
Sender: Adrien Nader

In my current patch for bug #712, I change the behaviour of AskFollow so that "true" means "follow" (i.e. like the doc states).

I'd like to be sure which behaviour is the right one.

(I hadn't noticed that issue and only changed it because I rewrote the relevant function instead of copying it)

Attached Files:

Changes:

No Changes Have Been Made to This Item